eroth
Need support UICollectionViewScrollDirectionHorizontal.
I'm trying to use UICollectionViewScrollDirectionHorizontal with ERJustifiedFlowLayout. It does one line horizontal scroll well. But some cells in view overlap each other. Can it be fixed? Thanks.
Hi--there's some bug fixes I need to push out in a new version. What you're seeing seems similar to what they address. I'll do that later today and you can see if it fixes your issue.
On Jun 15, 2016, at 07:19, internalG [email protected] wrote:
I'm trying to use UICollectionViewScrollDirectionHorizontal with ERJustifiedFlowLayout. It does one line horizontal scroll well. But some cells in view overlap each other. Can it be fixed? Thanks.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Attached 2 screenshots. I think FlowLayoutHorizontalJustificationRight + UICollectionViewScrollDirectionHorizontal is weird combination. FlowLayoutHorizontalJustificationLeft + UICollectionViewScrollDirectionHorizontal should be good.
Oh, I didn’t read your message correctly from earlier that you were trying to use it horizontally! That’s actually a use case I didn’t make handling for, since I only needed it for vertical scrolling when I made this layout. And since the layout’s UICollectionViewScrollDirection enum defaults to UICollectionViewScrollDirectionVertical if nothing is selected, that’s why it works if you don’t set a value for scrollDirection. Yes, this definitely doesn’t work with horizontal scrolling. Are you just trying to do it for one line, or multiple lines? The bug fixes I mentioned before wouldn’t affect this.
On Jun 15, 2016, at 10:20 PM, internalG [email protected] wrote:
https://cloud.githubusercontent.com/assets/834419/16103462/870fd446-33ab-11e6-8fbd-d97174e7f320.png https://cloud.githubusercontent.com/assets/834419/16103463/8719d98c-33ab-11e6-8234-5ec0ef20cf34.png Attached 2 screenshots. I think FlowLayoutHorizontalJustificationRight + UICollectionViewScrollDirectionHorizontal is weird combination. FlowLayoutHorizontalJustificationLeft + UICollectionViewScrollDirectionHorizontal should be good.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eroth/ERJustifiedFlowLayout/issues/8#issuecomment-226371762, or mute the thread https://github.com/notifications/unsubscribe/ABw_sXcneToUg06CfXbPsJqJQ8akfsPjks5qMLLdgaJpZM4I2QLq.
One line is enough. The first screenshot is nearly good except the position of cells.
Actually I think the layout has no need to calculate anything to work with UICollectionViewScrollDirectionHorizontal. The default implementation of UICollectionViewScrollDirectionHorizontal in iOS should work with your ERJustifiedFlowLayout. Just keep the cells size themselves. Right?
What my layout does is to calculate the positioning and spacing of the cells in each row, in accordance with the justification that you select. I’m not sure what you’re doing with your cell sizing, but I would think that if you want to use my layout it would have to perform layout calculations to enforce the justification settings.
On Jun 16, 2016, at 4:24 AM, internalG [email protected] wrote:
Actually I think the layout has no need to calculate anything to work with UICollectionViewScrollDirectionHorizontal. The default implementation of UICollectionViewScrollDirectionHorizontal in iOS should work with your ERJustifiedFlowLayout. Just keep the cells size themselves. Right?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eroth/ERJustifiedFlowLayout/issues/8#issuecomment-226420173, or mute the thread https://github.com/notifications/unsubscribe/ABw_sf3kAJ3nUL-5xjri2nkFk7OS9VpIks5qMQhYgaJpZM4I2QLq.