otp icon indicating copy to clipboard operation
otp copied to clipboard

inet_config: Tolerate atoms as `inetrc` kernel argument

Open jhogberg opened this issue 1 year ago • 2 comments

Many RabbitMQ users provided atoms instead of strings as the inetrc file path because of an error in their documentation. This was tolerated by accident until atom filename support was removed from erl_prim_loader.

We did the latter for good reason, but tolerating this specifically in inet_config is no big deal.


Fixes #8899. I figured that simply tolerating it was better than raising an error as it's difficult to present it in a way that makes sense, given how this argument is often provided on the command line.

jhogberg avatar Oct 04 '24 13:10 jhogberg

CT Test Results

    2 files     70 suites   1h 5m 48s :stopwatch: 1 548 tests 1 305 :white_check_mark: 243 :zzz: 0 :x: 1 764 runs  1 489 :white_check_mark: 275 :zzz: 0 :x:

Results for commit 0ac1427f.

:recycle: This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

github-actions[bot] avatar Oct 04 '24 13:10 github-actions[bot]

@jhogberg on behalf of the entire RabbitMQ team, thank you for bringing back this really obscure behavior that does not necessarily make much sense.

michaelklishin avatar Oct 04 '24 15:10 michaelklishin