erlang
Issue #8099: Add binary:join/2 to stdlib
CT Test Results
2 files 96 suites 1h 7m 38s :stopwatch: 2 163 tests 2 115 :white_check_mark: 48 :zzz: 0 :x: 2 523 runs 2 473 :white_check_mark: 50 :zzz: 0 :x:
Results for commit 7a3bd5c5.
:recycle: This comment has been updated with latest results.
To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.
See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.
Artifacts
// Erlang/OTP Github Action Bot
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Fwiw, there was an attempt at this a few years back, that ended up not making it due to a core team decision. It's possible, though, that stuff's changed since then.
After the first release candidate, we generally focus on bug fixes and polishing of features already included or planned for the release. To ensure that Erlang/OTP 27 will be as good as it possibly can be, we need to minimize the time we spend on things not to be included in the release. Therefore, we will not review this pull request until after OTP 27 has been released. If we have not came back to it before September, feel free to remind us.
Now we are back working on Erlang/OTP 28. OTP Technical Board will have to it approve this addition to the binary module. It is likely that it will be approved within a week or two.
Meanwhile, I've pushed a commit with suggested clean ups and proper error handling. Please review. If you approve, please rebase on the latest master and squash into one commit.
Now we are back working on Erlang/OTP 28. OTP Technical Board will have to it approve this addition to the
binarymodule. It is likely that it will be approved within a week or two.Meanwhile, I've pushed a commit with suggested clean ups and proper error handling. Please review. If you approve, please rebase on the latest
masterand squash into one commit.
Thank you! Squashed and rebased now 👍