DarlingData icon indicating copy to clipboard operation
DarlingData copied to clipboard
Published 4 months ago • verified publisher icon erikdarlingdata

sp_QuickieStore: Correct UTC offsets

Open ReeceGoding opened this issue 1 year ago • 2 comments

Closes #449 by switching to use SWITCHOFFSET rather than our old arithmetic tricks with @utc_offset_minutes. I'll spin up some Docker containers on different time zones to provide more evidence that this is working. For now, I just have this screenshot from my British Summer Time instance. BST

Notice that the _UTC columns are unchanged. This is intentional and correct.

ReeceGoding avatar Jul 06 '24 21:07 ReeceGoding

@erikdarlingdata As requested. Must've been my fault. Guess I synced with the wrong branch before forking.

ReeceGoding avatar Jul 06 '24 22:07 ReeceGoding

More tests. I think this is the final proof that the code works.

Docker time zone "Pacific/Midway" (UTC -11:00) Midway

Docker time zone "Canada/Newfoundland" (UTC -03:30, but I think it's their summer time) iNewfoundland

Docker time zone "ETC/UTC" (UTC +00:00) UTC

Docker time zone "Pacific/Guam" (UTC +10:00) Guam

ReeceGoding avatar Jul 06 '24 23:07 ReeceGoding