Avoid CMake warning w/o breaking default build
This PR enables the CXX language in CMake script to avoid this build warning:
CMake Warning (dev) at /usr/share/cmake-3.22/Modules/GNUInstallDirs.cmake:239 (message):
Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
target architecture is known. Please enable at least one language before
including GNUInstallDirs.
Call Stack (most recent call first):
third_party/evmone/cmake/cable/CableBuildInfo.cmake:16 (include)
CMakeLists.txt:28 (include)
This warning is for project developers. Use -Wno-dev to suppress it.
but only after the default CMAKE_TOOLCHAIN_FILE has been set, so the build with default toolchain does not break.
Did you try including CableBuildInfo after project()? That's my usually fix for this warning.
Did you try including
CableBuildInfoafterproject()? That's my usually fix for this warning.
Thanks a lot for this suggestion!
Codecov Report
Merging #792 (dccdbd5) into master (8974ae7) will increase coverage by
0.04%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 74.95% 75.00% +0.04%
==========================================
Files 197 197
Lines 14379 14379
Branches 2285 2285
==========================================
+ Hits 10778 10785 +7
- Misses 2621 2622 +1
+ Partials 980 972 -8
| Impacted Files | Coverage Δ | |
|---|---|---|
| core/silkworm/consensus/base/engine.cpp | 90.90% <0.00%> (-1.71%) |
:arrow_down: |
| core/silkworm/types/block.cpp | 87.00% <0.00%> (-0.50%) |
:arrow_down: |
| core/silkworm/execution/evm.cpp | 93.84% <0.00%> (-0.50%) |
:arrow_down: |
| core/silkworm/types/transaction.cpp | 82.10% <0.00%> (+0.31%) |
:arrow_up: |
| core/silkworm/consensus/blockchain.cpp | 88.70% <0.00%> (+0.80%) |
:arrow_up: |
| node/silkworm/rpc/server/call.hpp | 70.57% <0.00%> (+0.85%) |
:arrow_up: |
| core/silkworm/state/in_memory_state.cpp | 92.18% <0.00%> (+1.04%) |
:arrow_up: |
| node/silkworm/rpc/server/server_context_pool.cpp | 61.78% <0.00%> (+1.62%) |
:arrow_up: |
| node/silkworm/rpc/completion_end_point.cpp | 95.34% <0.00%> (+6.97%) |
:arrow_up: |
| core/silkworm/consensus/pos/engine.cpp | 100.00% <0.00%> (+16.66%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.