silkrpc icon indicating copy to clipboard operation
silkrpc copied to clipboard

Refactor TraceCallExecutor unit tests

Open canepat opened this issue 3 years ago • 0 comments

Unit tests for TraceCallExecutor should be refactored to improve readability and semantics:

  • add constructor in EVMExecutor with silkworm::State as input parameter instead of core::rawdb::DatabaseReader
  • add constructor in TraceCallExecutor with silkworm::State and EVMExecutor as input parameters instead of core::rawdb::DatabaseReader or change TraceCallExecutor::execute
  • if possible, refactor EVMExecutor and TraceCallExecutor to avoid templates
  • mock silkworm::State using Gmock
  • refactor unit tests
  • rename TraceCallExecutor as TraceExecutor

canepat avatar Jul 22 '22 09:07 canepat