get unlimted txns from txpool

Open leowkong opened this issue 3 years ago • 2 comments

erigon miner use cfg.txPool2.Best(200, &txSlots, poolTx)) to fetch 200 txns in SpawnMiningCreateBlockStage , but geth miner will fetch as much txns as possible from txpool and only conside gaslimit when commitTrancations in execution, so can we change Best(200) to Best(INT.MAX) to make miner more efficent? and let erigon execution stage to judge whether it has exceed limit (this code already realized in the picture in stage_mining_exec.go)

Sep 21 '22 06:09 leowkong

https://github.com/ledgerwatch/erigon/blob/68cc6e461264cb63c4e8fb332ae528478db74279/eth/stagedsync/stage_mining_create_block.go#L133 for reference

Sep 21 '22 08:09 PeaStew

Dropping a comment to link the two similar issues #5435

Sep 21 '22 09:09 hexoscott

Raised PR #6160 to tackle this

Nov 30 '22 14:11 hexoscott