Eric Wennerberg comments

Results 28 comments of


                                            Eric Wennerberg

fix(type): Correctly map proto to json according to spec

Hello @paulip1792, thanks for contributing. I ran the CI pipeline, and youre missing the changes to generated code in your commit. For my understand have you seen any isues with...

fix(type): Correctly map proto to json according to spec

I agree we should address this. As it turns out we rarely use `int64` in our protobuf schemas, so that is likely why we have not noticed it. Thanks for...

fix(type): Correctly map proto to json according to spec

@paulip1792 Is this still something you want to work on fixing?

Add generate options

@tonybase please take a look at the failing CI. Regarding commit messages we enforce conventional commits in order to automatically tag new versions. I suggest squashing all commits and prefixing...

[Bug] When using uint64 or fixed64 types, string should be generated instead of number

This sounds great, PRs welcome!

[Question] Is it possible to add option to output enum value number?

Hello @shuqingzai, this is a good suggestion, and PRs welcome for this.

Server-side streaming support

This plugin does not yet support server-side streaming, as we have not had a use-case for it. If you feel up for adding that support, please go ahead!

mat: calculate Q lazily when calling QR.ToQ

Hey @kortschak, is there anything I can help with to push this PR to the finish line?