ericw-tools icon indicating copy to clipboard operation
ericw-tools copied to clipboard
verified publisher icon ericwa

vis perf regression in 0.18.2rc1

Open ericwa opened this issue 6 years ago • 2 comments

Looks like a change in the latest RC is causing the major slowdown. I get: (Ryzen 2700x, 16 threads, Linux): tyrutils-0.15: 42.0s | ericw-tools 0.18.1: 45.3s | ericw-tools 0.18.2rc1: 143.1s

benchmark from: https://www.quaddicted.com/tools/vis_benchmark

ericwa avatar Apr 12 '19 02:04 ericwa

Can confirm:

AMD Ryzen 5 3600 6-Core Processor, ericw-tools-v0.18.1-Linux: 41.2s AMD Ryzen 5 3600 6-Core Processor, ericw-tools-v0.18.1-32-g6660c5f-Linux: 137s

SpiritQuaddicted avatar Aug 10 '21 16:08 SpiritQuaddicted

Yeah.. :(

I'm pretty sure this commit caused it btw. https://github.com/ericwa/ericw-tools/commit/74e1a0f6f02a2a469ebf6d7c05c175096cfe01a3

ericwa avatar Aug 10 '21 16:08 ericwa

Fixed in c94d44ae61c4e3e18d88a0f49bf7957cc0c69f1a

ericwa avatar Nov 12 '23 00:11 ericwa