Regression(?) in shadows & _mirrorinside

[JackViney96]

In ericw-tools 0.18.2-rc1, the shadows underneath this palm tree look like this:

In 0.18.1, the lighting still has issues, particularly on the side facing the sun. However the undersides seem to be lit a little more realistically.

I assume this is related to the fixes for _mirrorinside in the new release, as it is in use on these bmodels. The difference between the two examples is that the one that is completely black on the underside is not using the _phong key. Here is a source map for testing: palmtest.zip

[ericwa]

Thanks for testing :)

For the 0.18.2-rc1 screenshots, the one with the solid black underside is lit "correctly" in the sense that there's no light feature in use that should allow any light to reach the bottom faces.

Something is breaking on the phong one causing the lightmap or normals to wrap around to the bottom side of the palm branch, and pick up light, I'll check it out.

As far as getting more realistic lighting on these, some kind of "two sided lighting" model flag could be an idea.. I'll have to think about it a bit more.

[JackViney96]

Two sided lighting would be perfect for this kind of application where the intent is to have light diffusing through leaves etc. so that'd be a treat to see. I'm going to keep using the new RC and I'll let you know if I see any more issues.