gargoyle icon indicating copy to clipboard operation
gargoyle copied to clipboard

Themes broken by new GUI

Open lantis1008 opened this issue 8 years ago • 19 comments

Need to bring themes inline with new UI Assigning this to myself, but happy for anyone to assist.

  • [x] Gargoyle Classic
  • [ ] Gargoyle Modern (half done, could use polishing)
  • [x] Green Theme
  • [x] Light Theme
  • [x] Theme by Matei
  • [x] Dark One
  • [ ] Demantoid
  • [ ] Horchata
  • [x] Xeye

lantis1008 avatar Sep 09 '17 09:09 lantis1008

Provided basic screenshots to assist

lantis1008 avatar Sep 09 '17 09:09 lantis1008

How's the progress so far ? I'm having a go with "Xeye" (halfway there) and "Theme by Matei", based on your changes to Light/Green Themes.

screencapture-192-168-1-1-access-sh-1505179939691

Not sure how to approach "Demantoid"/"Horchata" due to custom menu layout.

d3fz avatar Sep 12 '17 01:09 d3fz

Thanks for doing that. I'm also avoiding those two for that exact reason, but I will get to them eventually. I'm having a look at cleaning Gargoyle-Modern as it got kind of forgotten in the process of getting Gargoyle-Classic up to spec.

lantis1008 avatar Sep 12 '17 03:09 lantis1008

No problem. Xeye is pretty much finished. Having a look at the other one now.

Edit: almost there. screencapture-192-168-1-1-access-sh-1505267281220

d3fz avatar Sep 12 '17 22:09 d3fz

By default, these themes were all centered with width ~ 900px, "wasting" useful available space. Should we make then full-width or leave as it is ?

Just need to make sure it doesn't break when going mobile, and some minor tweaks.

After that is pretty much finished.

d3fz avatar Sep 13 '17 02:09 d3fz

Agreed. I made them 1300px wide (if I remember correctly) to give the same feel as the old themes, whilst maximising space. This size auto shrinks as the window does, so no usability issues with the themes I've done.

up to you, if you want a new spin on it which is full width and not centered, go for it.

lantis1008 avatar Sep 13 '17 02:09 lantis1008

Yes, increasing max-width to 1300px makes it a lot better, so i'm just gonna leave as it is. I actually like the centered layout.

Once i'm finished, where/how can i send it to you ?

d3fz avatar Sep 13 '17 13:09 d3fz

You can create your own PR if you like, or send via a file sharing site etc. no problem

lantis1008 avatar Sep 13 '17 20:09 lantis1008

I've tried to match them as close as possible without breaking anything, looking pretty close.

There you go: https://ufile.io/726bh

I'm sending via shared file so you can take a look and perhaps include into your already opened PR.

I've also added two additional .png files:

  1. Modified "favicon.png" (transparent background). I got it from another user who posted a theme on the forum. It's an improvement over the current one, imo.
  2. Compressed (lossless) "globe-and-flags.png". Drops from 13kb to 5kb.

Let me know what you think.

d3fz avatar Sep 14 '17 23:09 d3fz

That all sounds good. Will check and review this evening. Thanks

lantis1008 avatar Sep 14 '17 23:09 lantis1008

I see this in theme Flat blue. No text. Any ideas? img-2020-04-17-16-04-38

Joro711 avatar Apr 17 '20 13:04 Joro711

Was fixed by commit https://github.com/ericpaulbishop/gargoyle/commit/904cb1626749a4ee34bb011c856214ebc7b8b11e Would need to install from an updated package repository. Or make the change manually yourself (it is only a few lines).

lantis1008 avatar Apr 17 '20 13:04 lantis1008

Thank you! Where i get update ipk file or how to change manually css file? Sorry for my bad english!

Joro711 avatar Apr 17 '20 17:04 Joro711

Either by building it yourself, or using a build provided on the forums. Manually changing the css file is just done by changing the file at /www/themes/flat-blue/theme.css to include the additional lines from https://github.com/ericpaulbishop/gargoyle/commit/904cb1626749a4ee34bb011c856214ebc7b8b11e You can make those changes using something like WinSCP or SSH, using the guides on the forums: https://www.gargoyle-router.com/phpbb/viewtopic.php?f=8&t=8505

lantis1008 avatar Apr 19 '20 09:04 lantis1008

@lantis1008 I think it's about time I finish the modern gargoyle theme. Is the color scheme staying the same as is? Any specific changes/suggestions? Compiling latest build now...

stopspazzing avatar Sep 26 '20 23:09 stopspazzing

Welcome back Colour scheme as you please. Having it at least somewhat resemble the Gargoyle purples would be great, but that is what Gargoyle classic is for so no stress.

lantis1008 avatar Sep 27 '20 00:09 lantis1008