Sublime-Text-2-Perforce-Plugin icon indicating copy to clipboard operation
Sublime-Text-2-Perforce-Plugin copied to clipboard
verified publisher icon ericmartel

First steps to migrate to sublime text 3

Open rdeangelis83 opened this issue 12 years ago • 5 comments

Hi Eric,

I hope you're feeling better :)

I have started to make some changes so that the plugin is now working in Sublime-Text-3.

I know it is by far not perfect but must of the feature are working again in Sublime-Text-3 :)

BR Rocco

rdeangelis83 avatar Jul 01 '13 22:07 rdeangelis83

@rdeangelis83 you may find that my pull request (https://github.com/ericmartel/Sublime-Text-2-Perforce-Plugin/pull/17) contains very similar changes :-)

maheshjag avatar Jul 04 '13 11:07 maheshjag

@maheshjag Yep looks very similar :) But I have seen that you only decode the result of the subprocess but whats about the error? e.g. WarnUser(err.strip()) does this work without decode?

rdeangelis83 avatar Jul 04 '13 12:07 rdeangelis83

Hi guys,

Sorry for the time it took for me to reply, but please check the Sublime-Text-3-Perforce-Plugin repo for all things ST3. Considering the name of the repo it wouldn't make sense to change it for ST3 while potentially breaking the ST2 integration.

Thanks! :)

ericmartel avatar Jul 04 '13 14:07 ericmartel

LOL -> First Commit -> 2 months ago :)

rdeangelis83 avatar Jul 04 '13 16:07 rdeangelis83

@rdeangelis83 Yes, it seemed to work without decode. But then again, my use of the plugin isn't extensive.

Thanks @ericmartel, I'm going to look up the other repo tomorrow. Super work!

maheshjag avatar Jul 23 '13 20:07 maheshjag