Eric Ferreira comments

Repositories
Issues
Comments

Results 37 comments of


                                            Eric Ferreira

Fix types and validation in `env` helper

> Hey @ericbf Thanks for this PR - the type improvements and validation additions are definitely valuable improvements to the `env` helper. 👍 > > I wanted to discuss two...

Fix types and validation in `env` helper

@Bassel17 I’ve reduced the scope of this PR to just the type fixes. Can you re-open? Thanks! Or let me know and I can open a new PR with the...

Fix types and validation in `env` helper

I’ve also created a new PR with the same changes (#24881). We can close that one if this one gets re-opened. But I don’t want this to get missed as...

home-filled size

Can we re-open this?

home-filled size

This is still an issue on the latest version webfont, `3.34.1`: This is an issue in chrome, seems to work in Safari.

fix: count grouped rows

What’s the hold-up here?

fix: count grouped rows

@fratzinger can you resolve the merge conflicts?