numpy_ringbuffer icon indicating copy to clipboard operation
numpy_ringbuffer copied to clipboard

Add handling of negative indices to getitem

Open pourhouse opened this issue 8 years ago • 1 comments

This will handle cases of ringbuf[-<n>], which were failing when self._arr is not full.

This may address the needs of your Issue #5, but I suspect it will not handle accesses when the index selector is an array_like with negative items.

pourhouse avatar Jan 11 '18 01:01 pourhouse

Codecov Report

Merging #6 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   98.49%   98.58%   +0.08%     
==========================================
  Files           3        3              
  Lines         266      282      +16     
==========================================
+ Hits          262      278      +16     
  Misses          4        4
Impacted Files Coverage Δ
tests.py 98.76% <100%> (+0.1%) :arrow_up:
numpy_ringbuffer/__init__.py 98.31% <100%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 341c8db...cd47b57. Read the comment docs.

codecov-io avatar Jan 11 '18 01:01 codecov-io