Doug Coleman

Results 116 comments of Doug Coleman

Dup of https://github.com/factor/factor/issues/2012 ?

We have a few longest so far: ``` factor ! Rename this to ``longer`` ! euler014 : longest ( seq seq -- seq ) 2dup [ length ] bi@ >...

I went with making `longest` output a sequence because it seems more generally useful and the `longest length` reads naturally. Fixed in dfe6a811e58980872e42ef1b1e7452b48b484b4c.

Actually, we could have `max-lengths` and `min-lengths` too... And why does `map-reduce` not work on sequences of length zero? Maybe we could make it do something else?

`longest length` gets the `length` twice. Hmm.

Let's completely fix and close this issue for .96.

Something like this would work. ``` factor : supremum-by' ( seq quot: ( ... elt -- ... x ) -- elt n ) [ [ first dup ] dip call...

We have this now. ```factor : longest ( seqs -- elt ) [ length ] supremum-by ; ``` We would have to make the comparators return the pre-compare results and...

Crashes in ``collect_aging()`` in ``visitor.visit_all_roots()`` line 82.