proteus icon indicating copy to clipboard operation
proteus copied to clipboard

TriangleTools.py removed

Open davidbrochart opened this issue 6 years ago • 2 comments

There used to be an interface to Triangle in proteus/TriangleTools.py (see https://proteustoolkit.org/api/proteus.TriangleTools.html). The file is not present in master. Is it not supported any more?

davidbrochart avatar Dec 05 '19 07:12 davidbrochart

That's correct. The license for triangle is problematic, and we decided to go the route of file-based interaction through the triangle CLI, as we do with tetgen for 3D meshes. I guess we need to clean up the docs and double check that we have all the functionality we need. /cc @tridelat

cekees avatar Dec 05 '19 14:12 cekees

@davidbrochart @cekees yes those need to be removed manually so it can be hard to catch. As they were committed previously for the documentation, and even though these files are not (re)generated anymore when building the docs, they are still there and will appear on the website unless explicitly deleted first. Btw, doc is probably going to move to https://github.com/erdc/proteus-doc at some point (rendered at https://erdc.github.io/proteus-doc/ ), which is a work in progress

tridelat avatar Dec 05 '19 17:12 tridelat