neqsim-python icon indicating copy to clipboard operation
neqsim-python copied to clipboard

prepare for use of jneqsim

Open EvenSol opened this issue 1 year ago • 4 comments

We will start using the jneqsim package to link Java Neqsim to neqsim-python. The jneqsim package does not add extra Python functionality to Neqsim (it is just an interface to the Neqsim Java library), but it facilitates the generation of stubs.

If only Java functionality is needed in your Python application using Neqsim, then direct use of jneqsim is recommended. However, neqsim-python adds functionality and wrappers that can simplify calculations and shorten the scripts.

jneqsim is not yet updated to v3.0.0, so we need to wait for this version to be available for it to work.

EvenSol avatar Oct 15 '24 20:10 EvenSol

I support the change but want to test a bit before approving this.

Specifically I want to verify the overload done by "from jneqsim import neqsim"

asmfstatoil avatar Oct 16 '24 19:10 asmfstatoil

The tests are currently failing because of conflicting definitions of python module neqsim

asmfstatoil avatar Oct 17 '24 11:10 asmfstatoil

I would await https://github.com/equinor/jneqsim/pull/15

asmfstatoil avatar Oct 24 '24 07:10 asmfstatoil

I am not sure it is worth it to do "from jneqsim import neqsim" and overwrite the package structure that neqsim python package defines, it will have funky behaviour, but I was able to make the tests work.

I would still recommend "from jneqsim import neqsim as jneqsim" and have a clean separation between python neqsim package objects and java neqsim objects.

It is nice to get the neqsim jars from jneqsim instead of manually updating them here :)

asmfstatoil avatar Oct 29 '24 22:10 asmfstatoil