lms icon indicating copy to clipboard operation
lms copied to clipboard

LMS sends artist coverArt ID even if there is no cover art

Open splintering opened this issue 2 years ago • 1 comments

It seems LMS is sending a coverArt ID for artists over the OS API even if the artist has no cover.

This leads to obsolete requests from clients (in my case Symfonium) for the cover art which always and predictably end in a HTTP 404:

2024-03-15 17:48:32.681 Error/ImageCacheManager: Error downloading image [404] - http://192.168.xx.yy:zzzz/rest/getCoverArt.view?id=**ar-11**&u=REDACTED&p=REDACTED&v=1.13.0&c=Symfonium&f=json

I think there is now way for the clients to predict the result, so the proper behaviour would probably be to not send a coverArt ID if no cover art is there?

splintering avatar Mar 15 '24 17:03 splintering

Ah yes you are right, I forgot about this problem. Thanks for reporting!

epoupon avatar Mar 15 '24 18:03 epoupon

Fixed by https://github.com/epoupon/lms/pull/490

epoupon avatar Jul 06 '24 15:07 epoupon