Willie Scholtz
Willie Scholtz
> I added new tests with less complex objects and some of them are failing. Please take a look and see if you can make them pass. > > I...
@harawata Looking at the result for `testImmutableNestedObjects` , it is being built correctly, we just need to final signal somehow; ~~let me know if I should investigate this~~ I found...
Thanks @harawata! Also appreciate all the time you have put into this :) Yeah, the discriminator is definitely a bit more tricky, i.e we won't be able to discriminate results...
imo, if we are going to throw an exception when an ambiguous key is detected, we might as well remove the inner class entirely and do that where it is...
It ran the initial benchmarks on this PR, but failed to post the comments due to permissions. I changed the event to be pull_request_target, so it will only start running...
Thank you for the feedback @harawata, I should have been more clear, the included benchmark is just a dummy, this PR was more meant to showcase that we can have...
@harawata > And, in case we adopt this, I would also like to see memory usage which is equally important as execution speed (I assume it's not included in the...
Think we can close this one now @harawata :)
Fixed as part of #101
Question, is this behaviour explicitly for records now? I believe that if we change the reflector it should be consistent with how a normal class is reflected aswell, not _only...