Foundation icon indicating copy to clipboard operation
Foundation copied to clipboard

setup.sh has out-date-command paths and syntax

Open nsideras opened this issue 1 year ago • 2 comments

Describe the bug The setup.sh script does not work on macOS out-of-the box due to old command paths and syntax.

To Reproduce Steps to reproduce the behavior:

  1. Follow the Mac installation steps
  2. Run setup.sh as instructed

Expected behavior The script should configure the site databases.

Instead, the sqlcmd commands in the Docker container fail due to a path error, and the dotnet-episerver commands sometimes fail due to the command not being found, particularly when dotnet is installed with homebrew. (See #825 )

Screenshots

Image

Desktop (please complete the following information):

  • OS: macOS
  • Because these errors occur when calling dotnet commands and while setting up the Docker container, I assume these errors also occur with Linux when running the same setup.sh script.

Additional context It looks like the script has old paths set for sqlcmd. In addition, the site appsettings is set to always trust the SQL Server certificates, but the sqlcmd commands fail on a certificate trust issue. Finally, the dotnet episerver commands appear to be using an older syntax (dash vs space) that can fail in some cases.

Previous issues such as #825 also mention difficulty running the script in the default zsh shell.

nsideras avatar Jan 27 '25 15:01 nsideras

I've added PR #973 that fixes these issues, and as best as I can test on my machines gets setup.sh working out-of-the-box again.

nsideras avatar Jan 27 '25 15:01 nsideras

Thanks @nsideras for the patch. It worked for me in Linux as well.

phdhiren avatar May 04 '25 08:05 phdhiren