Manos Pitsidianakis
Manos Pitsidianakis
Perhaps it's a timing issue (we need to wait for a few milliseconds/ a second for the bus to setup). What do you think, @dorindabassey?
You can try running it locally again and again for an hour or more until it fails to confirm it happens, then add a `sleep 5` before the test starts...
It seems like buildkite is cancelling it (IIRC there are no timeouts in cargo tests): ```text # Received cancellation signal, interrupting ``` I wonder if there's a way to improve...
This change is definitely necessary. Path names are not guaranteed to be UTF-8 hence why Path/OsStr exists.
@bilelmoussaoui are you interested in picking this up again? We started doing this on the other device crates (see latest PRs)
Implemented in https://github.com/rust-vmm/vhost-device/pull/819
Making this into a draft PR since CI lacks rustfmt on nightly toolchain
> Yeah, LGTM, just a couple of questions: > > * should we also remove the lints in `staging/vhost-device-sound/src/lib.rs` ? We need to update the CI rust to 1.74 first,...
https://github.com/rust-vmm/vhost-device/blob/573e592037d971058eda39d6f04ae2322d8f0701/staging/vhost-device-sound/src/lib.rs#L261 The doc comment can be similar to the commit that introduced the field: > sound: add latency_bytes field to IOMessage > > The latency field specifies how long it...
@MatiasVara I had the same thought when I first read the code. My interpretation ended up being that the sound card should not be "kicked" (interrupted) until `delay` more frames...