code style

[sbfnk]

It would be good to run styler/lintr for a consistent and better readable code style

[joshwlambert]

@sbfnk requested that this should be addressed after we've integrated the changes from the h5n1 branch into main.

[sbfnk]

after we've integrated the changes from the h5n1 branch into main.

Is there still a plan for this to happen? Might get more tricky as code bases diverge.

[joshwlambert]

I'm using the current model implementation (i.e. incubation period and skew-normal) to run some analyses. Once these are done I was planning on integrating the changes on the h5n1 branch which uses a parameterisation of the serial interval to control the tempo of transmission (in addition to use of incubation period). The changes are relatively minor so it shouldn't be too much work even if the code bases have diverged.

As the code has changed quite a bit over the last few PRs I think we can address this issue prior to integrating the h5n1 changes, let me know what you prefer and I can assign myself to this issue.

[joshwlambert]

Due to the divergence between the code in the main branch and the h5n1 branch given recent developments, and the plan to integrate the h5n1 branch not in the immediate future, I've addressed this issue in PR #127. The code style is now more consistent and produces fewer {lintr} warnings (although there are a few remaining linter warnings that I will address as I continue to develop the package).

I didn't run styler::style_pkg() in #127, running a pilot to preview the results of running {styler} the differences are minimal. Mostly just removing the empty line between the function signature and function body present in many {ringbp} functions. This can easily be applied at a later date is desired.