epiforecasts
mention PR authors / reviewers in NEWS.md
We dropped this in EpiNow2 because it became a bit of a pain to maintain, and it's not really useful information to the user. Using allcontributors in the README mitigates some of the issue with attributing credit.
I'd suggest to remove mentions of authors, reviewers and PR numbers from the NEWS file.
I personally don't have a preference. Mentioning authors and reviewers in the NEWS.md give more granularity to contributions than allcontributors, but I've not consistently used this style of news bullets so if you've found from {EpiNow2} it's a bit cumbersome then I'm happy to revert.
On other GH organisations I've worked on, the default is always mention PR number and mention GH handle if contributor is external. This seems to closely mirror the tidyverse style:
If the bullet is related to an issue, include the issue number. If the contribution is a PR, and the author is not a package author, include the GitHub user name.
That sounds really sensible. I would prefer to mention Issue number (as in the tidyverse quote) over PR number as that's known at the time of composing the PR.
Not sure why but I've changed my preference on the NEWS.md. I now prefer the current setup of
[change description] "Addresses" [issue no.] "by" [GitHub username] "in" [PR no.] "and reviewed by" [GitHub username(s)]
Apologies for being contrarian, I'm fine being outvoted on this and can implement either this or the tidyverse approach in a CONTRIBUTING.md once decided.