ratelimit icon indicating copy to clipboard operation
ratelimit copied to clipboard

Make the default hitsAddend configurable

Open gcalmettes opened this issue 1 year ago • 1 comments

The current minimum hitsAddend value is set to 1 (enforced via a Max function). This prevents uses cases where the request itself would not carry any "weight" (e.g.: request to check a quota).

Could we make the minimum hitsAddend value configurable so 0 could also be a possible hitsAddend value for a request ?

gcalmettes avatar Oct 10 '24 13:10 gcalmettes

PR for a proposed implementation, leveraging the current Settings.

gcalmettes avatar Oct 10 '24 13:10 gcalmettes

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 09 '24 16:11 github-actions[bot]

not stale

gcalmettes avatar Nov 09 '24 16:11 gcalmettes

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 09 '24 20:12 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Dec 17 '24 00:12 github-actions[bot]