nighthawk icon indicating copy to clipboard operation
nighthawk copied to clipboard

Stop using deprecated mock method macros

Open dubious90 opened this issue 3 years ago • 0 comments

When running fix_format, it will give a complaint like the following:

ERROR: From ./../nbperry-nighthawk/test/test_common/mock_stream.h
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:15: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:18: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:21: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:31: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:34: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:35: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:38: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:41: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead
ERROR: ./../nbperry-nighthawk/test/test_common/mock_stream.h:42: The MOCK_METHODn() macros should not be used, use MOCK_METHOD() instead

I considered this outside the scope of fixing formatting, but as a followup we should probably move to MOCK_METHOD.

dubious90 avatar Sep 21 '22 20:09 dubious90