go-control-plane Switch to new Go protobuf v2 module

Upstream switched to a new Go protobuf module, protobuf v2. go-control-plane should fully switch over to this so that client projects can switch too. I think the main change that will be needed is to switch the protoc toolchain over to generate wrapper code with the new module.

Dec 13 '21 22:12 jpeach

+1 for this. We looked into this previously and I believe the action items were:

Update rules_go: https://github.com/bazelbuild/rules_go/issues/2522
Update Envoy's internal bazel pipeline
Update the build script: https://github.com/envoyproxy/envoy/blob/main/tools/api/generate_go_protobuf.py

Here's an issue for reference: https://github.com/envoyproxy/go-control-plane/issues/403

I can try and help out with this @jpeach but I'm not super skilled/familiar with bazel. I can stumble my way around if you do need me to tackle something though

Dec 14 '21 15:12 alecholmez

Update rules_go: proto: add go_proto_apiv2 and go_grpc_apiv2 compilers bazelbuild/rules_go#2522

Oof, that does not look promising ...

Dec 14 '21 22:12 jpeach

Oof, that does not look promising ...

Yea... this is a big rabbit hole I went down a while back, might be worth revisiting though

Dec 26 '21 03:12 alecholmez

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

Feb 06 '22 01:02 github-actions[bot]

This should be fixed with rules_go v0.33.0: https://github.com/bazelbuild/rules_go/issues/2522#issuecomment-1158138179

Jun 16 '22 21:06 arnehormann

I have a PR open for this now: https://github.com/envoyproxy/envoy/pull/21790

Jun 20 '22 17:06 alecholmez

Okay looks like this pr: https://github.com/envoyproxy/envoy/pull/21790 got merged so we can now proceed here. @jpeach would you be interested in picking this back up?

Jun 21 '22 20:06 alecholmez

Okay looks like this pr: envoyproxy/envoy#21790 got merged so we can now proceed here. @jpeach would you be interested in picking this back up?

I can probably take a look in a week or so.

Jun 23 '22 01:06 jpeach

https://github.com/envoyproxy/go-control-plane/pull/607

Would like to know if we will resolve this issue together with this PR?

Dec 14 '22 12:12 yckbilly1929

@jpeach

Fixed by https://github.com/envoyproxy/go-control-plane/commit/db0b36a50fa8230b3f8edd718f108a64c74d7880

Mar 27 '24 06:03 mmorel-35