gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Support setting idle timeout time function based on data flow

Open bjlhlin opened this issue 1 year ago • 4 comments

…triage

What type of PR is this?

feat: Support setting idle timeout time function based on data flow What this PR does / why we need it:

Which issue(s) this PR fixes: EG currently does not support setting idle timeout times based on data streams. This PR supports this feature

Fixes #3671

bjlhlin avatar Jun 25 '24 01:06 bjlhlin

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.25%. Comparing base (51c6eb4) to head (9a77cf2).

:exclamation: Current head 9a77cf2 differs from pull request most recent head 2302ddb

Please upload reports for the commit 2302ddb to get more accurate results.

Files Patch % Lines
internal/gatewayapi/clienttrafficpolicy.go 0.00% 5 Missing and 1 partial :warning:
internal/xds/translator/listener.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3672      +/-   ##
==========================================
- Coverage   68.81%   68.25%   -0.56%     
==========================================
  Files         175      170       -5     
  Lines       21525    20768     -757     
==========================================
- Hits        14812    14176     -636     
+ Misses       5636     5571      -65     
+ Partials     1077     1021      -56     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 25 '24 07:06 codecov[bot]

please kindly submit API change first.

zirain avatar Jun 26 '24 04:06 zirain

please kindly submit API change first.

Where can I write this information

bjlhlin avatar Jun 26 '24 12:06 bjlhlin

please kindly submit API change first.

Where can I write this information

you can remove everything under /internal, we shall start reviewing changes under /api first.

shawnh2 avatar Jun 27 '24 08:06 shawnh2

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 30 '24 04:07 github-actions[bot]

closing this PR since its become inactive, feel free to reopen if you're still working on it

arkodg avatar May 23 '25 02:05 arkodg