gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: adding support for ext auth and backend mtls

Open alexwo opened this issue 1 year ago • 2 comments

What this PR does / why we need it: This enables the use of a shared client certificate with Envoy proxies when accessing external services or backends.

Approach: We introduce the capability to associate a TLS client certificate with the global configuration of an Envoy proxy. When configured, this client certificate will be used by the proxies when connecting to specified backends or external services, as determined by the presence of TLS routes.

  • Extra e2e tests are added

Which issue(s) this PR fixes: https://github.com/envoyproxy/gateway/issues/2536

alexwo avatar May 20 '24 18:05 alexwo

Codecov Report

Attention: Patch coverage is 67.36842% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 67.18%. Comparing base (2880a55) to head (5edafcd).

Files Patch % Lines
internal/xds/translator/translator.go 15.00% 14 Missing and 3 partials :warning:
internal/provider/kubernetes/controller.go 23.52% 13 Missing :warning:
internal/gatewayapi/backendtlspolicy.go 97.91% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
+ Coverage   67.15%   67.18%   +0.02%     
==========================================
  Files         166      166              
  Lines       19463    19544      +81     
==========================================
+ Hits        13071    13131      +60     
- Misses       5447     5469      +22     
+ Partials      945      944       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 18:05 codecov[bot]

@alexwo Thanks for working on this!

Could you please add e2e tests to this PR directly? This is not a very large PR, incorporating these tests would not be a burden for reviewers.

Hi @zhaohuabing ,

Sure, I have added the e2e tests as part of this PR.

alexwo avatar May 20 '24 18:05 alexwo

/retest

alexwo avatar May 21 '24 08:05 alexwo

/retest

alexwo avatar May 21 '24 09:05 alexwo

/retest

alexwo avatar May 21 '24 10:05 alexwo

/retest

alexwo avatar May 22 '24 13:05 alexwo

/retest

alexwo avatar May 22 '24 14:05 alexwo

/retest

alexwo avatar May 22 '24 15:05 alexwo

/retest

alexwo avatar May 22 '24 15:05 alexwo

/retest

alexwo avatar May 22 '24 16:05 alexwo

/retest

alexwo avatar May 23 '24 07:05 alexwo

/retest

alexwo avatar May 23 '24 09:05 alexwo

@alexwo - can you maybe make some of the suggested test improvements in a follow-up PR?

guydc avatar May 24 '24 00:05 guydc

@alexwo - can you maybe make some of the suggested test improvements in a follow-up PR?

yes sounds good! , thanks for the quick review & feedback.

alexwo avatar May 24 '24 05:05 alexwo