gateway icon indicating copy to clipboard operation
gateway copied to clipboard

refactor: Do we refactor sinks on observables?

Open ShyunnY opened this issue 2 years ago • 2 comments

I found that in the API observable configuration, using a lot of different Sink or Provider. For example: EnvoyGatewayOpenTelemetrySink, and the configuration of Provider in the Ratelimit Trace I am doing (#2974).

Essentially, no matter when we configure the OTEL Sink of metrics or trace, it is the configuration of the exporter. Do we need to build the configuration in https://github.com/open-telemetry/opentelemetry-specification/blob/v1.8.0/specification/protocol/exporter.md into a common object so that it can share the place where the OTEL Sink needs to be configured in the API?

Like the following:

type OTELSink struct {
	Protocol string 

	Endpoint string 

	Insecure *bool 

	Timeout string

        CertificateFile string

        Headers map[string][string]
}

ShyunnY avatar Mar 20 '24 05:03 ShyunnY

blocked on https://github.com/envoyproxy/gateway/issues/3041

arkodg avatar Mar 28 '24 08:03 arkodg

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Apr 27 '24 12:04 github-actions[bot]