gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Create Helm chart for upstream gateway-api resources

Open arkodg opened this issue 2 years ago • 7 comments

Description:

Currently the gateway-api CRDs and Admission Server resources live in the /crds folder in the Helm Chart, which makes it hard to optinally delete and optionally install these resources.

Moving it into its own chart would help user decide if they'd like to opt in to installing the gateway-api resources when installing EG.

Relates to https://github.com/envoyproxy/gateway/issues/1361#issuecomment-1641044645 & https://github.com/envoyproxy/gateway/pull/1548#issuecomment-1641056455

arkodg avatar Jul 27 '23 16:07 arkodg

@youngnick is this something that be generated in upstream, or should EG maintain its own chart for Gateway-API ?

arkodg avatar Jul 27 '23 16:07 arkodg

@youngnick will upstream plan to provide helm-chart?

zirain avatar Jul 28 '23 02:07 zirain

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Aug 27 '23 04:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Nov 20 '23 00:11 github-actions[bot]

I looked into this. The gateway api maintainers do not provide an upstream helm chart that we can source as a dependency.

Personally, I think that the envoy-gateway helm chart should leave the installation of these CRDs to the users: Just list it as a requirement, and link to their installation docs.

Due to this bundling of Gateway API CRDs and envoy-gateway CRDs, using the helm chart gets a bit fiddly for us when installing into our Google Kubernetes Engine clusters:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: envoy-gateway-system

helmCharts:
  - name: gateway-helm
    releaseName: envoy-gateway
    # The helm chart includes Gateway API, which we already install through a GKE Addon
    includeCRDs: false
    # GKE uses an older version of Gateway API than the latest helm chart
    # https://gateway.envoyproxy.io/v1.0.0/install/matrix/
    version: v0.5.0
    repo: oci://registry-1.docker.io/envoyproxy
    valuesFile: ./values.yaml

resources:
  - https://raw.githubusercontent.com/envoyproxy/gateway/v0.5.0/charts/gateway-helm/crds/generated/config.gateway.envoyproxy.io_envoyproxies.yaml
  - https://raw.githubusercontent.com/envoyproxy/gateway/v0.5.0/charts/gateway-helm/crds/generated/gateway.envoyproxy.io_authenticationfilters.yaml
  - https://raw.githubusercontent.com/envoyproxy/gateway/v0.5.0/charts/gateway-helm/crds/generated/gateway.envoyproxy.io_envoypatchpolicies.yaml
  - https://raw.githubusercontent.com/envoyproxy/gateway/v0.5.0/charts/gateway-helm/crds/generated/gateway.envoyproxy.io_ratelimitfilters.yaml

djfinnoy avatar Apr 03 '24 20:04 djfinnoy

thanks for raising this @djfinnoy !

arkodg avatar Apr 05 '24 07:04 arkodg

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar May 05 '24 08:05 github-actions[bot]

closing in favor of https://github.com/envoyproxy/gateway/issues/4001

arkodg avatar Sep 11 '24 23:09 arkodg