envoyproxy
Revert "rbac: add delay_deny implementation in RBAC network filter (#…
…33875)"
This reverts commit bf65ad3ab24a6c3cb2b60cdb2e043dea6e32c2ac.
Fix #35653
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/35899 was opened by phlax.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
Three weeks past. This revert will also introduce a unexpected/break API change. cc @envoyproxy/api-shepherds
Or could we disable the test temporarily if that is not an actual bug? cc @yangminzhu
Seems the @yangminzhu has no activity on GitHub recently.
Then, let's revert it directly if no explicit objection from @envoyproxy/api-shepherds
sorry I missed the message, I will look into the test.
@wbpcode @ggreenway I have a question regarding the process of reverting an API/feature change, Is that a new norm in Envoy or a documented process? such revert could easily break users who depend on the API/feature. People may not be able to monitor the Envoy github for various reasons, I wonder if there is a better way to review/approve the decision of reverting, and communication/notify to the message since it could have a major impact on Envoy users.
@yangminzhu we sometimes revert changes when they cause test failures in CI, when there's no clear path to forward-fix. We would not ever revert a change with an API change that has been released; reverts only happen for recent commits that have not been included in a release.
Aside from monitoring github, there's not a good way to stay in the loop. Github is our collaboration platform for the project. Often if a contributor can produce a fix for a flaky test, we'll use that instead of a revert, but that only works if the contributor is responsive.
@wbpcode @ggreenway ok, I will monitor the Github more, appreciate if you could also ping me on Slack next time if I wasn't replying on Github. and I have the fix out https://github.com/envoyproxy/envoy/pull/37776, please take a look, thanks.