envoy icon indicating copy to clipboard operation
envoy copied to clipboard

generic proxy: move generic proxy from contrib into extensions

Open wbpcode opened this issue 1 year ago • 7 comments

Commit Message: generic proxy: move generic proxy from contrib into extensions Additional Description:

The generic proxy is designed as a framework to empower the developers to develop new L7 proxy for various L7 protocols. It's be used for multiple different private protocols now in the production env of our users. And recently, I complete the last part of generic proxy: the filter chain support to the variable length stream. And except the private protocols, we use the generic proxy implement the kafka proxing and pulsar proxing and conditional traffic routing. (part of these works are contributed back to the envoy).

After an offline discussion with other maintainers, I prepare to move the generic proxy to the extensions now.

Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a.

wbpcode avatar Jun 25 '24 09:06 wbpcode

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @adisuissa CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34892 was opened by wbpcode.

see: more, trace.

/coverage

wbpcode avatar Jun 26 '24 09:06 wbpcode

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/34892/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/34892#issuecomment-2191284360 was created by @wbpcode.

see: more, trace.

/coverage

wbpcode avatar Jun 27 '24 03:06 wbpcode

Coverage for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/34892/coverage/index.html

The coverage results are (re-)rendered each time the CI envoy-presubmit (check linux_x64 coverage) job completes.

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/34892#issuecomment-2193295831 was created by @wbpcode.

see: more, trace.

/retest

wbpcode avatar Jun 28 '24 12:06 wbpcode

/retest

wbpcode avatar Jun 28 '24 13:06 wbpcode

It LGTM, but it seems the CI still not happy

soulxu avatar Jul 08 '24 02:07 soulxu

/wait

soulxu avatar Jul 08 '24 02:07 soulxu

Just for confirmation, this is normal extension, so I think one approval from maintainer is enough? cc @alyssawilk

wbpcode avatar Jul 08 '24 13:07 wbpcode

Generally I'd say senior maintainer approval for initial import but AFIK you have Matt's thumbs up on slack so yeah I'd say any approval is fine.

alyssawilk avatar Jul 08 '24 13:07 alyssawilk

was prechecks broken prior to this PR? I'm seeing it fail on main now where it wasn't before my last sync, but it could have been a numbe ro fPRs

alyssawilk avatar Jul 09 '24 13:07 alyssawilk