envoy icon indicating copy to clipboard operation
envoy copied to clipboard

[balsa] Add tests to document behavior when header value contains CR or LF.

Open bencebeky opened this issue 1 year ago • 1 comments

These characters are invalid according to RFC9110 Section 5.5 [1]. Either the message must be rejected, or the characters replaced by SP according to the RFC. These tests confirm that both http-parser and BalsaParser indeed either reject the message or remove the forbidden characters, though neither of them seem to insert a SP in their place.

Balsa implementation tracking issue: #21245

[1] https://www.rfc-editor.org/rfc/rfc9110.html#name-field-values

Commit Message: Add tests to document behavior when header value contains CR or LF. Additional Description: Risk Level: low, test-only change Testing: test/common/http/http1:codec_impl_test Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

bencebeky avatar May 10 '24 15:05 bencebeky

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/34088 was opened by bencebeky.

see: more, trace.

/assign @yanavlasov

bencebeky avatar May 14 '24 15:05 bencebeky