envoy icon indicating copy to clipboard operation
envoy copied to clipboard

remove runtime guard: outlier detection - enforce max_ejection_percentage

Open Pawan-Bishnoi opened this issue 1 year ago • 3 comments

Commit Message: remove runtime guard Risk Level: low Testing: all tests green Docs Changes: n/a Release Notes: n/a? Fixes #33613

Pawan-Bishnoi avatar Apr 18 '24 10:04 Pawan-Bishnoi

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/33657 was opened by Pawan-Bishnoi.

see: more, trace.

changing to draft while I work on this ask

Removing the runtime var and making it configurable should still be acceptable imo.

Pawan-Bishnoi avatar Apr 29 '24 09:04 Pawan-Bishnoi

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar May 29 '24 12:05 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 05 '24 12:06 github-actions[bot]