envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Add disallowed_headers knob to ext_authz config

Open antoniovleonti opened this issue 2 years ago • 15 comments

Commit Message: Add disallowed_headers knob to ext_authz config Additional Description: This PR adds a config field to ext_authz that will prevent the specified headers from being sent to the external authentication service. This new field (disallowed_headers) will always override the allowed_headers field. Risk Level: low Testing: unit tests & integration tests Docs Changes: none Release Notes: added to changelog Platform Specific Features: n/a [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

antoniovleonti avatar Apr 04 '24 19:04 antoniovleonti

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @wbpcode CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/33349 was opened by antoniovleonti.

see: more, trace.

/assign @tyxia

antoniovleonti avatar Apr 04 '24 19:04 antoniovleonti

/retest

antoniovleonti avatar Apr 04 '24 21:04 antoniovleonti

/retest

antoniovleonti avatar Apr 05 '24 13:04 antoniovleonti

/retest

antoniovleonti avatar Apr 08 '24 12:04 antoniovleonti

/assign @yanjunxiang-google

Could you take a first pass on it? Thanks

tyxia avatar Apr 08 '24 15:04 tyxia

Just realized, #33244 should probably be merged before this one.

#33244 refactors HttpFilterTestParam, which is a parameterized test fixture used to write some of this PR's tests.

antoniovleonti avatar Apr 09 '24 17:04 antoniovleonti

ping me if this is ready for a maintainer review. :)

wbpcode avatar Apr 10 '24 12:04 wbpcode

/wait

RyanTheOptimist avatar Apr 11 '24 19:04 RyanTheOptimist

This PR is ready for review. @wbpcode

antoniovleonti avatar Apr 23 '24 15:04 antoniovleonti

/wait-any

wbpcode avatar Apr 25 '24 03:04 wbpcode

@yanjunxiang-google please review

antoniovleonti avatar May 03 '24 13:05 antoniovleonti

/retest

antoniovleonti avatar May 03 '24 16:05 antoniovleonti

/retest

antoniovleonti avatar May 08 '24 17:05 antoniovleonti

@wbpcode I think I need your API review again.

antoniovleonti avatar May 09 '24 12:05 antoniovleonti

@wbpcode ping for api re-review

ravenblackx avatar May 14 '24 15:05 ravenblackx

/lgtm api

wbpcode avatar May 15 '24 06:05 wbpcode

Because @tyxia is the owner and has approved this PR. And it's LGTM, so will merge it directly. :)

wbpcode avatar May 15 '24 06:05 wbpcode