envoyproxy
subset_lb: add metadata_fallback_policy
Signed-off-by: Marcin Falkowski [email protected]
Commit Message: subset_lb: add metadata_fallback_policy
Additional Description: The problem, context and solution idea is explained here: https://github.com/envoyproxy/envoy/issues/20063
Risk Level: Low/Medium - a new feature that is disabled by default, but also very small changes to existing logic (no behavior changes expected)
Testing:
- unit tests
- manual testing
Docs Changes:
new protos API field described (cluster.v3.Cluster.LbSubsetConfig.metadata_fallback_policy)
Release Notes: added Platform Specific Features: N/A
Fixes #20063
[Optional API Considerations:] new API feature: metadata_fallback_policy:
- the default value does not cause behavior changes for existing users
- users have a way to disable this change if it causes problems
- it is not plausible that its default value may change in the future
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/22442 was opened by MarcinFalkowski.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/22442 was opened by MarcinFalkowski.
https://github.com/envoyproxy/envoy/issues/20063#issuecomment-1070335927
@zuercher I hope this implementation is manageable, or we can make it manageable in the review process :)
https://github.com/envoyproxy/envoy/issues/20063#issuecomment-1065525691
@rgs1 I would appreciate your review
BTW. The original issue is closed now due to inactivity. I don't know if that's a problem, but in case it is - I don't know how to reopen it.
