envoy icon indicating copy to clipboard operation
envoy copied to clipboard

Switch to no-throw version of proto unpack

Open tyxia opened this issue 3 years ago • 7 comments

Throwing exception (i.e., causing crash) should be avoided in data plane Signed-off-by: Tianyu Xia [email protected]

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional API Considerations:]

tyxia avatar Jun 15 '22 02:06 tyxia

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/21706 was opened by tyxia.

see: more, trace.

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 15 '22 04:07 github-actions[bot]

This PR depends on #21987 which implements the no-throw version of the utility function that can be used by caller site here

tyxia avatar Jul 15 '22 14:07 tyxia

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Aug 14 '22 20:08 github-actions[bot]

/retest

tyxia avatar Aug 21 '22 22:08 tyxia

Retrying Azure Pipelines: Retried failed jobs in: envoy-presubmit

:cat:

Caused by: a https://github.com/envoyproxy/envoy/pull/21706#issuecomment-1221628634 was created by @tyxia.

see: more, trace.

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Sep 21 '22 00:09 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Sep 28 '22 00:09 github-actions[bot]