envoy-perf icon indicating copy to clipboard operation
envoy-perf copied to clipboard

[Salvo] Use Salvo to measure real commits in Envoy repo

Open gyohuangxin opened this issue 3 years ago • 3 comments

Use Salvo to measure real commits in Envoy repo to find out what can be improve for Salvo and its test cases. Then convert the example of fake commits to the real commits.

gyohuangxin avatar Mar 17 '22 05:03 gyohuangxin

@mum4k Sorry for the absence due to some critical work, I tried to measure real commits you mentioned before, but the commit id seems not be found from main branch in cloned repo.

$ git clone https://github.com/gyohuangxin/envoy && cd envoy
$ git checkout 461bec3bf2a29b56d1117f28df3a0894914d3952
fatal: reference is not a tree: 461bec3bf2a29b56d1117f28df3a0894914d3952

This commit id was 461bec3bf2a29b56d1117f28df3a0894914d3952 image

Do you have any idea about how to fix it?

gyohuangxin avatar Apr 06 '22 03:04 gyohuangxin

I think 461bec3bf2a29b56d1117f28df3a0894914d3952 is a commit ID before https://github.com/envoyproxy/envoy/pull/19115 was merged onto the main branch.

Envoy uses Squash commits, which means all commits reviewed in the PR get squashed together and result in a single commit into the main branch. We should be using this commit ID instead. This can be found in the conversation history of https://github.com/envoyproxy/envoy/pull/19115 where it was merged in:

Screen Shot 2022-04-06 at 11 26 25 PM

Verified that this is available in a clone of the Envoy repository:

$ git clone https://github.com/envoyproxy/envoy && cd envoy
$ git log | grep 02dff6e0235e2f497fb57eb0b7c07cc091c538df
commit 02dff6e0235e2f497fb57eb0b7c07cc091c538df

mum4k avatar Apr 07 '22 03:04 mum4k

@mum4k Thank you, it confused me for a long time. Now it works.

gyohuangxin avatar Apr 08 '22 06:04 gyohuangxin

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 14 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 19 '22 08:11 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 104 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

github-actions[bot] avatar Dec 04 '22 08:12 github-actions[bot]