envoy-mobile Fix Android certificate validation JNI calling convention

Use JNI parameter ordering defined for instance methods (instead of the static methods one). Add tests to avoid regressions.

#1575

Sep 02 '22 13:09 StefanoDuo

/retest

Sep 05 '22 12:09 StefanoDuo

@danzh2010 Would you like to review this yourself or should I send this to someone else?

P.S. I'll address the other things we chatted offline (use of find_class & installing android class loader) in a separate CL (I don't think it's possible to create child CLs on GitHub).

Sep 05 '22 14:09 StefanoDuo

/retest

Sep 07 '22 11:09 StefanoDuo

/assign @RyanTheOptimist

Sep 08 '22 16:09 danzh2010

The swift failure is unrelated. /assign @danzh2010

Sep 08 '22 16:09 danzh2010

@StefanoDuo is this ready to merge?

Sep 22 '22 19:09 RyanTheOptimist

/wait

Sep 22 '22 19:09 RyanTheOptimist

/wait

Nov 01 '22 14:11 RyanTheOptimist

/retest

Nov 04 '22 15:11 StefanoDuo

/retest

Nov 04 '22 17:11 StefanoDuo

P.S. Sorry for the late follow-up. I've been OOO for the past month.

AFAIU, most of these CL has been merged by @danzh2010 through https://github.com/envoyproxy/envoy-mobile/pull/2554. What's missing is just these additional tests, that prevent the calling convention bug to resurface in the future.

I've rebased and updated the code to reflect that.

Nov 07 '22 13:11 StefanoDuo

Closing this PR as this repo is now archived. You can open a new PR in the Envoy repo if you'd like: https://github.com/envoyproxy/envoy

Dec 06 '22 15:12 jpsim