Jáchym Toušek
Jáchym Toušek
@JanTvrdik It look good. Except that I'd like to use those generators for future version of EntityLoader as well.
I finished my update from PHPStan 1.4 to PHPStan 1.8 and the CI runs time (when there is no result cache) went from ~24 mins to ~62 mins. :flushed:
@bsweeney Tried to debug it myself for a bit. First thing I found was that `Helpers::getFileContent()` probably does not work with data urls. It is called by `FontMetrics::registerFont()`. There is...
The CI failure seems to be unrelated.
Ok so the preventDefault actually needs to be called. I'm not sure why you added stopPropagation as well though - that's what causing my problems. When I remove the stopPropagation...
In my use case the stopPropagation needs to be removed only from dragover and drop. I removed it from dragenter just to be consistent.
I've tested in Firefox, Chrome and IE11. Oh so you just copied it without knowing why? Well preventDefault stops the browser from doing its default operation - in this case...
@LPology I'm aware but dragenter doesn't really work in this case. Trust me, I've tried to get it working without dragover. It can't be done. The solution is bad but...
I do agree with yout that with the `stopPropagation` removed you can no longer be so sure about the behaviour. However the behavior could only break because of this by...