node-esl icon indicating copy to clipboard operation
node-esl copied to clipboard

Issue #84 -- emit esl::end on socket::close

Open ssinyagin opened this issue 6 years ago • 3 comments

net.Socket emits "end" only on successful closing, but it emits "close" in error conditions as well.

ssinyagin avatar Jan 06 '20 21:01 ssinyagin

Thanks for tracking this down. Looks like this breaks one of the tests, can you look into why that is please?

englercj avatar Jan 07 '20 02:01 englercj

seems like you're expecting connection::close while the socket is still alive. With my patch, the close event comes when the socket is done.

ssinyagin avatar Jan 10 '20 10:01 ssinyagin

Makes sense, I'm happy to merge this once the tests are passing.

englercj avatar Jan 11 '20 18:01 englercj