toro icon indicating copy to clipboard operation
toro copied to clipboard

I get callback to error player

Open aderinto05 opened this issue 7 years ago • 5 comments

What kind of issue is this?

  • [x] Question. If so, declare clearly your target and your current implementation with code formatted in markdown.

  • [ ] Bug report. If so, please supply the way to reproduce the issue, including addition information as follow:

    • [ ] Toro version.
    • [ ] Android version (can be found in Device info). Rooted/Custom rom devices are not supported.
    • [ ] Device name (eg: Nexus 5X, Samsung Galaxy S8)
    • [ ] Source code that can reproduce the issue (a snapshot is expected).
    • [ ] Logcat stack trace in case of fatal issue.
  • [ ] Feature request. Start by telling me what problem you’re trying to solve. Don’t send pull requests to implement new features without first getting my support. Sometimes I leave features out on purpose to keep the project small.

  • [ ] Other. Senseless issues are normally ignored. Please understand and cooperate.

aderinto05 avatar Dec 05 '18 08:12 aderinto05

why sometimes I got callback to onPlayerError(ExoPlaybackException error) with error is null? can you explain.

aderinto05 avatar Dec 05 '18 08:12 aderinto05

@aderinto05 The callback from ExoPlayer right? May need to check their implementation as well :(.

eneim avatar Dec 06 '18 02:12 eneim

i got error callback from toroplayer @eneim

aderinto05 avatar Dec 06 '18 11:12 aderinto05

@aderinto05 Can you try a debug and see from which the method is called? I do not manually call this, so it must be from ExoPlayer. But looking around the source code it doesn't have a null. I also find this on ExoPlayer: https://github.com/google/ExoPlayer/issues/4262, can you refer to it as well?

Also, please give me the version of Toro you are using ...

eneim avatar Dec 06 '18 12:12 eneim

It's call this exception com.google.android.exoplayer2.upstream.HttpDataSource$HttpDataSourceException: java.net.SocketTimeoutException: timeout I'm using im.ene.toro3:toro:3.5.2

aderinto05 avatar Dec 11 '18 07:12 aderinto05