uvicorn icon indicating copy to clipboard operation
uvicorn copied to clipboard
verified publisher icon encode

Support for sendfile

Open lovelydinosaur opened this issue 8 years ago • 3 comments

Support sendfile usage.

Would require an ASGI extension.

lovelydinosaur avatar Jun 27 '17 11:06 lovelydinosaur

Relevant:

  • https://github.com/aio-libs/aiohttp/issues/1093
  • https://github.com/MagicStack/uvloop/issues/61
  • https://twitter.com/1st1/status/1017771823130431490

lovelydinosaur avatar Jul 13 '18 14:07 lovelydinosaur

Are there any estimate when will V1.2 milestone come out?

est avatar Jun 29 '20 08:06 est

https://asgi.readthedocs.io/en/latest/extensions.html#zero-copy-send The relevant ASGI documentation has been completed.

abersheeran avatar Oct 05 '20 15:10 abersheeran

Given @tomchristie 's comment on the PR that implemented sendfile support, and the fact that there were not many interested in this feature over the years, I'll be closing this issue.

If people are interested, we can always reevaluate this decision.

Kludex avatar Dec 05 '22 06:12 Kludex

@Kludex If/when this feature gets developed I will merge zerocopysend support into WhiteNoise.

Adding support within WhiteNoise would be fairly quick, but I don't know if I will have time on the immediate horizon to PR this into uvicorn. I have too many prior OSS commitments so it would most likely be a year or two before I could get to this.

Archmonger avatar Jul 28 '23 12:07 Archmonger

I would also like to express my interest in this feature as my server does quite a bit of file-io which I would like to offload

septatrix avatar Feb 19 '24 23:02 septatrix

Related:

  • https://github.com/django/asgiref/issues/423

Archmonger avatar Feb 20 '24 00:02 Archmonger