typesystem icon indicating copy to clipboard operation
typesystem copied to clipboard

Customizing error messages & internationalization.

Open lovelydinosaur opened this issue 6 years ago • 2 comments

  • We'll want to mark up our error messages as translatable strings.
  • Support an errors = {} argument for overriding the error strings.
  • Support errors as an attribute adding the the defaults, rather than overriding them.

lovelydinosaur avatar Mar 04 '19 09:03 lovelydinosaur

  • We'll want to mark up our error messages as translatable strings.
  • Support an errors = {} argument for overriding the error strings.
  • Support errors as an attribute adding the the defaults, rather than overriding them.

In my forked version of the repo, I've added the ability to override error messages via passing over additional optional keyword arguments to the Field class. I also needed to pass an optional placeholder message for the input form. It can address some of these issues.

This is sort of my first real attempt at contributing to a project so not sure what protocol I should follow. I read the contribution guidelines about prior discussion.

Are you open to me submitting a PR? @aminalaee

smartexpert avatar Feb 13 '22 03:02 smartexpert

@smartexpert Hey, that looks good.

To be honest I think we won't be adding new features to the project as it's not being maintained actively.

If you want maybe you can do #124 in typesystem but the main focus is on projects pinned in the Encode organisation like HTTPX, Starlette and Uvicorn and any kind of contribution is welcome :)

aminalaee avatar Feb 13 '22 10:02 aminalaee