starlette icon indicating copy to clipboard operation
starlette copied to clipboard

Skip magic trailing comma

Open jonathanberthias opened this issue 1 year ago • 1 comments

Summary

There have been many comments asking contributors to merge lines where possible such as this one. There is an option available in the Ruff formatter to do this automatically, at the expense of ignoring magic trailing commas: skip-magic-trailing-comma, and a sibling isort option for imports: split-on-trailing-comma.

This change reformats a lot of code, so I would understand if you prefer not merging this.

Checklist

  • [x] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [ ] I've updated the documentation accordingly.

jonathanberthias avatar Feb 09 '24 15:02 jonathanberthias

We can merge this and, add a .git-blame-ignore-revs in a subsequent commit.

Kludex avatar Feb 09 '24 21:02 Kludex

Yeah, let's not merge this. 👍

Thanks for letting me know about those flags, anyway.

Kludex avatar Feb 29 '24 10:02 Kludex