httpcore icon indicating copy to clipboard operation
httpcore copied to clipboard

Socks proxy should support read/write timeouts

Open Anthonybelui opened this issue 2 years ago • 1 comments

Discussed in https://github.com/encode/httpcore/discussions/859

Originally posted by Anthonybelui December 16, 2023 Hello, thanks for developing the library. I wanted to ask you to fix/define the logic for the read timeout in socks_proxy. This creates an infinity reading.

File httpcore/_sync/socks_proxy.py Function _init_socks5_connection() Line: incoming_bytes = stream.read(max_bytes=4096) > incoming_bytes = stream.read(max_bytes=4096, timeout=SomeTimeout)

Anthonybelui avatar Dec 22 '23 15:12 Anthonybelui

I opened a PR fixed this: https://github.com/encode/httpcore/pull/868

iamdrq avatar Jan 08 '24 06:01 iamdrq

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 04:04 stale[bot]