samples icon indicating copy to clipboard operation
samples copied to clipboard

WRR-3609: Update major versions for dependencies

Open alexandrumorariu opened this issue 1 year ago • 0 comments

Enact-DCO-1.0-Signed-off-by: Alexandru Morariu [email protected]

Checklist

  • [X] I have read and understand the contribution guide
  • [ ] A CHANGELOG entry is included
  • [ ] At least one test case is included for this feature or bug fix
  • [X] Documentation was added or is not needed
  • [ ] This is an API breaking change

Issue Resolved / Feature Added

I updated the following dependencies:

  • readdirp from ^3.6.0 to ^4.0.1 (https://github.com/paulmillr/readdirp/releases/tag/4.0.0) Has breaking change for our project.

  • query-string from ^8.2.0 to ^9.1.0 (https://github.com/sindresorhus/query-string/releases/tag/v9.0.0) No breaking change for our project.

  • web-vitals removed from our project because it was not used inside the sample.

  • @types/node from ^20.14.9 to ^22.5.2 (no revelvant README.MD or CHANGELOG.MD, I tested this manually) No breaking change for our project.

I also updated the scripts to work with the changes made in readdirp 4.0.1

Resolution

In order to make our scrips work with the new version of readdirp I made some changes. First readdirp.promise was replaced by readdirpPromise. Second the import statement was changed from "const readdirp = require('readdirp')" to "const {readdirpPromise} = require('readdirp')". Third the directoryFilter type was changed from an array of strings to a function. All the changes were inspired from their README.MD file (https://github.com/paulmillr/readdirp?tab=readme-ov-file#readdirp-) examples 3) and 4).

I removed web-vitals from the project. I do agree with Daniel's comment that it was added based on our template.

Additional Considerations

Links

WRR-3609

Comments

alexandrumorariu avatar Sep 20 '24 11:09 alexandrumorariu