x icon indicating copy to clipboard operation
x copied to clipboard

[FEATURE]: My History dates locale should rely on uiLang

Open herrardo opened this issue 3 years ago • 14 comments

How can the project be improved?

Some commits ago, the uiLang parameter was added to the SnippetConfig.

This was made because now, the requests to the APIs rely in lang parameter, and if exist the lang shown by the UI components rely in the new uiLang parameter, so the components can have different locale for requests and UI using both parameters.

How can this be solved?

Change the MyHistory component to show dates based in uiLang instead of lang as locale.

Proposed solution

No response

Customizations supported

No response

Additional information

Make the first character of the date always uppercase to show

Miércoles, 19 de octubre de 2022

instead of

miércoles, 19 de octubre de 2022

In English the first is uppercase, but just because names of days and months are uppercase in English and toLocaleDateString is setting that in the right way. But in Spanish, or other languages, even if the name of the day is correctly written in lowercase, we would like to start the sentence in uppercase.

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct.

herrardo avatar Oct 19 '22 12:10 herrardo

Hi, I want to work on this issue. I'm new to open source

Dhananjay-12 avatar Nov 25 '22 18:11 Dhananjay-12

Hello @Dhananjay-12 I am assigning this issue to you. Sorry about not answering sooner!

herrardo avatar Dec 06 '22 07:12 herrardo

Hello @Dhananjay-12, I am unassigning you as it seems you couldn't start the PR.

Thanks!

herrardo avatar Feb 07 '23 15:02 herrardo

Is this issue still open ? Can i work on it

Tanmay3132 avatar Feb 25 '23 07:02 Tanmay3132

Yes @Tanmay3132 , go for it ;)

herrardo avatar Feb 27 '23 23:02 herrardo

Hey, can I work on this?

vbsh123 avatar Jun 25 '23 18:06 vbsh123

All yours, @vbsh123 :)

mavmaf avatar Jul 03 '23 15:07 mavmaf