emoncms icon indicating copy to clipboard operation
emoncms copied to clipboard

service runner pulling ENV vars for docker-compose (v2)

Open emrysr opened this issue 5 years ago • 1 comments

these changes allow the service runner to take ENV vars for the redis hostname and port number.

this will enable the v2 branch of docker-compose repo to connect to the correct redis server (instead of the default 'localhost' and '6379'

will fallback to above defaults if no ENV vars set.

merge this only for testing... currently v2 branch uses my repos

emrysr avatar Apr 08 '20 14:04 emrysr

The problem I see with this, is the specifying of the default in the code. This then breaks the link to the emoncms settings.

Can the documentation / readme be updated as part of the PR please.

borpin avatar Apr 08 '20 16:04 borpin