Version 2, remove querystring and use node/browser inbuilt capabilities

Open mikemaccana opened this issue 6 years ago • 2 comments

Hi @emerleite! This is only a small change to the code, but means the library is much smaller. All the tests still pass.

I've bumped the major version as it requires node 10.x as minimum (which is reasonable). I've added README and CHANGELOG entries too.

Jul 10 '19 17:07 mikemaccana

👍 for your effort but that has been already proposed.

Check last line of getQuery https://github.com/emerleite/node-gravatar/pull/45/files#diff-ee51e51d1083c0e4c9a8e3be0870eab9R46

Aug 25 '19 20:08 vladimyr

I found all these change reasonable - even if they are 3 years old :-(

@vladimyr I don't understand you "check last line"

Jun 04 '22 06:06 orefalo